Skip to content

[Storage] Support upload 4TB Azure file#13495

Merged
msJinLei merged 4 commits intoAzure:masterfrom
wastoresh:4tbfile2
Nov 20, 2020
Merged

[Storage] Support upload 4TB Azure file#13495
msJinLei merged 4 commits intoAzure:masterfrom
wastoresh:4tbfile2

Conversation

@blueww
Copy link
Member

@blueww blueww commented Nov 13, 2020 •
edited
Loading

Description

Upgrade Upload File cmdlet Set-AzStorageFileContent to Track2 SDK, so can upload file >1TB.
Also upgrade Az.Core to 1.6.0

Since the interface don't have any change, so don't need design review.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@dolauli dolauli modified the milestone: S178 (2020-11-17) Nov 13, 2020
@blueww blueww force-pushed the 4tbfile2 branch 2 times, most recently from ee5617d to dfeda92 Compare November 13, 2020 09:50
@erich-wang
change Azure.Core version to 1.6 (#10)
6491c5c
@erich-wang
Upgrade System.Buffers to 4.5 (#11)
fc2b935 
* change Azure.Core version to 1.6

* Upgrade System.Buffers to 4.5.0
@blueww
Copy link
Member Author

blueww commented Nov 18, 2020

@erich-wang
After merge the lastest commit from you, build and test pass, but static analysis fail since missing assemblies

/Users/runner/work/1/s/artifacts//StaticAnalysisResults/MissingAssemblies.csv:
"Directory","Assembly Name","Assembly Version","Referencing Assembly","Severity","ProblemId","Description","Remediation" "/Users/runner/work/1/s/artifacts/Debug/Az.Batch","System.Runtime.CompilerServices.Unsafe","4.0.4.0","Microsoft.Extensions.Primitives","0","3000","Missing assembly System.Runtime.CompilerServices.Unsafe referenced from Microsoft.Extensions.Primitives","Ensure that the assembly is included in the Wix file or directory" "/Users/runner/work/1/s/artifacts/Debug/Az.Batch","System.Text.Encodings.Web","4.0.3.0","Microsoft.AspNetCore.WebUtilities","0","3000","Missing assembly System.Text.Encodings.Web referenced from Microsoft.AspNetCore.WebUtilities","Ensure that the assembly is included in the Wix file or directory" "/Users/runner/work/1/s/artifacts/Debug/Az.Resources","System.Runtime.CompilerServices.Unsafe","4.0.4.0","Microsoft.Extensions.Primitives","0","3000","Missing assembly System.Runtime.CompilerServices.Unsafe referenced from Microsoft.Extensions.Primitives","Ensure that the assembly is included in the Wix file or directory"

Do you think the missing assemblies are OK? If so, I will add them to exception.

@blueww
Copy link
Member Author

blueww commented Nov 19, 2020

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Nov 19, 2020

Azure Pipelines successfully started running 3 pipeline(s).

@blueww
Copy link
Member Author

blueww commented Nov 20, 2020

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Nov 20, 2020

Azure Pipelines successfully started running 3 pipeline(s).

@msJinLei msJinLei merged commit a735ca7 into Azure:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@msJinLei msJinLei msJinLei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Waiting for CI :shipit:

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@blueww @msJinLei @azuresdkci @dolauli @erich-wang